Re: Review request: br-msk-lua, br-msk-libprofiling

From: Murray S. Kucherawy <>
Date: Tue, 22 Dec 2009 23:46:14 -0800 (PST)

On Tue, 22 Dec 2009, SM wrote:
>> br-msk-libopendkim contains some performance improvements to
>> libopendkim that I found while experimenting with Daniel's code
>> coverage and profiling work. The changes cut out a huge number of
>> calls to strlen() and make a few other minor optimizations. "make
>> check" on the library still passes all tests. This will be a pretty
>> short review.
> I'll do the review. Even though it is short, I don't think I would be
> able to do it over the next few days.

Great, thanks. By the way I got the branch name wrong; it's

>> I'm really keen to merge br-msk-lua before starting down the road of
>> reworking the data structures around the previously-discussed
>> scalability feature issues, so that one should take priority if
>> possible. Doing them in the opposite order will make the merge a great
>> deal more difficult. Unfortunately there's quite a bit to go over in
>> there.
> I want to look at that next as it opens new avenues.

Excellent. Let me know if you have any questions.
Received on Wed Dec 23 2009 - 07:46:36 PST

This archive was generated by hypermail 2.3.0 : Mon Oct 29 2012 - 23:32:30 PST